Vladsz83 commented on code in PR #13670:
URL: https://github.com/apache/ignite/pull/13670#discussion_r4260926432
##########
modules/calcite/pom.xml:
##########
@@ -69,12 +69,10 @@
<artifactId>ignite-core</artifactId>
</dependency>
- <!--
- Indexing is required for cross-engines tests.
- -->
<dependency>
- <groupId>${project.groupId}</groupId>
- <artifactId>ignite-indexing</artifactId>
+ <groupId>com.thoughtworks.xstream</groupId>
Review Comment:
Duplicate? Look below
##########
docs/_docs/setup.adoc:
##########
@@ -152,7 +152,7 @@ You can enable modules or extensions one by one, as
required.
All modules are included in the binary distribution, but by default they
are disabled (except for the `ignite-core`, `ignite-spring`,
`ignite-control-utility` and
-`ignite-indexing` modules). Modules can be found in the `libs/optional`
+`ignite-calcite` modules). Modules can be found in the `libs/optional`
Review Comment:
Check also the following docs pls:
- docs/_docs/SQL/indexes.adoc:24
- docs/_docs/SQL/sql-api.adoc:30
- docs/_docs/SQL/JDBC/jdbc-client-driver.adoc:25
- docs/_docs/setup.adoc:73
- docs/_docs/setup.adoc:85
- docs/_docs/setup.adoc:207
##########
modules/calcite-testing/README.txt:
##########
@@ -0,0 +1,6 @@
+Apache Ignite Calcite Testing Module
+------------------------------------
+
+Apache Ignite Calcite Testing module contains the tests that require both SQL
engines, Calcite (ignite-calcite)
Review Comment:
Suggestion: let's simplify like, split the sentences like:
`that require (the) both SQL engines: Calcite ('ignite-calcite') and H2
('ignite-indexing'). The classpath: cross ...`
##########
modules/calcite-testing/src/test/java/org/apache/ignite/testsuites/CalciteAndH2TestSuite.java:
##########
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.testsuites;
+
+import
org.apache.ignite.internal.processors.query.calcite.integration.CacheStoreTest;
+import
org.apache.ignite.internal.processors.query.calcite.integration.KeyClassChangeIntegrationTest;
+import
org.apache.ignite.internal.processors.query.calcite.integration.QueryEngineConfigurationIntegrationTest;
+import
org.apache.ignite.internal.processors.query.calcite.integration.ResultSetSizeMetricsTest;
+import
org.apache.ignite.internal.processors.query.calcite.integration.SqlPlanHistoryIntegrationTest;
+import
org.apache.ignite.internal.processors.query.calcite.integration.TimeoutIntegrationTest;
+import
org.apache.ignite.internal.processors.query.calcite.integration.ViewsIntegrationTest;
+import
org.apache.ignite.internal.processors.query.calcite.jdbc.JdbcCrossEngineTest;
+import
org.apache.ignite.internal.processors.query.calcite.thin.MultiLineQueryTest;
+import
org.apache.ignite.internal.processors.tx.TxWithExceptionalInterceptorTest;
+import org.junit.platform.suite.api.SelectClasses;
+import org.junit.platform.suite.api.Suite;
+
+/**
+ * Tests that require both SQL engines, Calcite and H2, on the classpath.
Review Comment:
```suggestion
* Tests that require both SQL engines on the classpath: Calcite and H2
('indexing').
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
