nizhikov opened a new pull request, #13695: URL: https://github.com/apache/ignite/pull/13695
Part of IGNITE-25090 (extract binary implementation from ignite-core). Sub-task: https://issues.apache.org/jira/browse/IGNITE-29153 **What.** Two commits, no behaviour change: 1. `BinariesFactory#unmarshal` is added and `GridBinaryMarshaller` goes through it instead of calling the package-private `BinaryUtils#unmarshal` directly. 2. The unmarshal switch and its `doRead*` helpers move out of `ignite-binary-api`. The 31 helpers used only by the reader become private static members of `BinaryReaderExImpl`; `checkProtocolVersion`, `length`, `doReadClassName` and `doReadOptimized`, which the builder and the offheap object also use, move to `BinaryImplUtils`. `doReadStringArray` stays in `BinaryUtils` because the thin client calls it. **Why.** Once the marshaller reaches `unmarshal` through the factory, the whole read family is referenced only from `ignite-binary-impl`, so it no longer belongs in the API module. Method bodies move verbatim; the diff outside `BinaryUtils`/`BinaryReaderExImpl` is four one-line call-site changes plus imports. **Checked.** `ignite-binary-api`, `ignite-binary-impl`, `ignite-core` compile; checkstyle passes on all three; core binary suites (`BinaryMarshallerSelfTest`, builder, enums, arrays, heap/offheap fields) pass, 857 tests. 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
