Vladsz83 commented on code in PR #13577:
URL: https://github.com/apache/ignite/pull/13577#discussion_r4298616927
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/SnapshotCheckProcess.java:
##########
@@ -131,7 +133,7 @@ private IgniteInternalFuture<?>
reduceValidatePartsAndFinish(
return new GridFinishedFuture<>();
try {
- contexts.remove(ctx.req.snapshotName());
+ contexts.remove(ctx.req.snapshotName().toLowerCase(Locale.ROOT));
Review Comment:
If we remove the ignored-case-names-comparison among `SnapshotCheckProcess`,
the test
`IgniteClusterSnapshotDeleteTest#testSnapshotDeleteWhenCheckInProgress` will
fail:
```
[2026-10-16T22:36:34,454][ERROR][main][] Test failed
[test=IgniteClusterSnapshotDeleteTest#testSnapshotDeleteWhenCheckInProgress[encryption=false,
onlyPrimary=false, incremental=false], duration=3836]
java.lang.AssertionError
at org.junit.Assert.fail(Assert.java:87)
at org.junit.Assert.assertTrue(Assert.java:42)
at org.junit.Assert.assertTrue(Assert.java:53)
at
org.apache.ignite.testframework.junits.JUnitAssertAware.assertTrue(JUnitAssertAware.java:35)
at
org.apache.ignite.internal.processors.cache.persistence.snapshot.IgniteClusterSnapshotDeleteTest.testSnapshotDeleteWhenCheckInProgress(IgniteClusterSnapshotDeleteTest.java:690)
```
on Windows (`caseInsensitiveFs ` is `true`)
The exception arises:
`class org.apache.ignite.IgniteException: Snapshot directory doesn't exists:
...\ignite\work\snapshots\testsnapshot`
Because without this change we allow concurrent removing snapshots on case
insensitive file systems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
