XianReallyHot-ZZH commented on PR #13732: URL: https://github.com/apache/ignite/pull/13732#issuecomment-6370224015
Hi @chesnokoff, thanks for the review! 1. Comments removed. 2. Adopted — replaced the per-module lists with a single `<proc>full</proc>` in the parent's compiler plugin configuration. The processors are then discovered through the ServiceLoader registration files shipped in ignite-codegen (and the immutables jar for calcite), which also means new modules depending on ignite-codegen get annotation processing for free. codegen's own `-proc:none` was switched from `<compilerArgument>` to the `<proc>` element so it overrides the parent deterministically. Verified on JDK 17.0.12 / 21.0.5 / 23.0.2 / 25.0.4.1 by clean-building the four modules and comparing the generated file sets — identical on every JDK: calcite 34 files, indexing 33, zookeeper 8, control-utility 2 (test sources). (Note: a full reactor build on 23/25 still fails in core's test sources due to the `Thread.suspend/resume` removal — pre-existing, unrelated to this change.) One caveat to flag: the `-proc:full` flag is only accepted from JDK 17.0.12 / 11.0.24 onward (backported), so building with 17.0.0–17.0.11 would fail with "invalid flag". CI uses the current 17.0.x so it is unaffected, but if older patch releases must stay buildable, this could be gated behind a `[21,)`-activation profile instead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
