XianReallyHot-ZZH opened a new pull request, #13739:
URL: https://github.com/apache/ignite/pull/13739

   ## Description
   
   Ticket: https://issues.apache.org/jira/browse/IGNITE-1025
   
   When the IP finder resolves a long list of addresses, node join/reconnect 
may take significant time: a connection attempt to an unavailable address 
usually blocks until socket timeout instead of failing fast (on Windows OS this 
typically looks like the node hangs for a while).
   
   This PR adds a throttled warning in `TcpDiscoverySpi.resolvedAddresses()` 
when the resolved address list exceeds `ADDRS_WARN_THRESHOLD` (20). The warning 
explains why startup can be slow and suggests making sure that all IP finder 
addresses are correct and reachable and reducing the address list.
   
   The warning is printed regardless of OS so it is deterministic and testable 
(CI runs on Linux), while the message text explains the Windows-specific 
amplification described in the ticket.
   
   Supersedes the stale attempt #2966 (closed in 2022 without review).
   
   ## Testing
   
   - [x] `TcpDiscoveryLongAddressListWarnSelfTest` added:
     - `testWarnOnLongAddressList` — 21 registered addresses → warning is 
printed.
     - `testNoWarnOnShortAddressList` — 3 registered addresses → no warning.
     - Uses loopback addresses with unused ports, so connection attempts fail 
fast on every OS (no dependence on Windows-specific behavior in the test).
   - [x] `mvn -pl modules/core test 
-Dtest=TcpDiscoveryLongAddressListWarnSelfTest` — 2/2 green (locally verified 
red before the fix as well).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to