oleg-vlsk commented on code in PR #13583:
URL: https://github.com/apache/ignite/pull/13583#discussion_r4433827242
##########
modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/IgniteCacheAbstractQuerySelfTest.java:
##########
@@ -1186,7 +1219,7 @@ public void testTwoObjectsTextSearch() {
new QueryEntity(String.class, ObjectValueOther.class)
));
- IgniteCache<Object, Object> c = jcache(ignite(), conf, Object.class,
Object.class);
+ IgniteCache<Object, Object> c = jcache(ignite(), conf,
"Object-Object");
Review Comment:
The existing `jcache(Ignite, CacheConfiguration, String)` overload only
copies the configuration, sets the cache name, and gets or creates the cache.
It does NOT modify query entities.
`jcacheWithSpecifiedName(...)` additionally adds a query entity for the
supplied key/value types if one is missing. Using it with `Object.class` here
would add an unnecessary entity, so I would keep the existing call. Overload
resolution is unambiguous with these three arguments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
