zstan commented on code in PR #13685: URL: https://github.com/apache/ignite/pull/13685#discussion_r4440537929
########## docs/_docs/SQL/sql-calcite.adoc: ########## @@ -181,13 +190,19 @@ IgniteConfiguration cfg = new IgniteConfiguration().setSqlConfiguration( === DDL -Data definition language (DDL) statements are compliant with the old H2-based engine. You can find the DDL syntax description link:sql-reference/ddl[here, window=_blank]. +You can find the DDL syntax description link:sql-reference/ddl[here, window=_blank]. The Calcite-based engine does not accept the following elements of the H2 dialect: + +* The `LONG` type name: use `BIGINT`. +* A precision of the integer types, such as `INT(11)`: use `INT`. +* The `affinityKey` and `cacheGroup` spellings of the `CREATE TABLE` options: use `AFFINITY_KEY` and `CACHE_GROUP`. +* The `PARALLELISM`, `PK_INLINE_SIZE` and `AFFINITY_INDEX_INLINE_SIZE` options of `CREATE TABLE`. +* Spatial indexes (`CREATE SPATIAL INDEX`) and the `GEOMETRY` data type. Review Comment: add here, I understand that this question related to different section check org.apache.ignite.IgniteJdbcDriver what about : PARAM_LOCAL, PARAM_COLLOCATED, PARAM_STREAMING, PARAM_STREAMING_FLUSH_FREQ, PARAM_STREAMING_PER_NODE_BUF_SIZE, PARAM_STREAMING_PER_NODE_PAR_OPS, PARAM_STREAMING_ALLOW_OVERWRITE - I found some of them are been mentioned in different parts, but some - seems no (fix me if I miss smth) Probably we need such a section ? ########## docs/_docs/SQL/sql-tuning.adoc: ########## @@ -1,438 +0,0 @@ -// Licensed to the Apache Software Foundation (ASF) under one or more Review Comment: Plz explain - why we need to remove this still helpful section ? I thisnk we need to store it, just append additional one for calcite based engine, wdyt ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
