Vladsz83 commented on code in PR #13599:
URL: https://github.com/apache/ignite/pull/13599#discussion_r4445210000


##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/GridDistributedTxRemoteAdapter.java:
##########
@@ -584,6 +584,11 @@ else if (conflictCtx.isMerge()) {
                                         // Nullify explicit version so that 
innerSet/innerRemove will work as usual.
                                         explicitVer = null;
 
+                                    // Explicit expire time is already 
reached: remove instead of storing an already
+                                    // expired value (the same way as for 
TTL_ZERO, see IGNITE-25194).
+                                    if ((op == CREATE || op == UPDATE) && 
CU.isExpired(txEntry.conflictExpireTime()))

Review Comment:
   Why do we change the operation at commit time? Is this behavior expected by 
users, especially for an update? And why doesn’t the same happen for GET?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to