zstan commented on code in PR #13769:
URL: https://github.com/apache/ignite/pull/13769#discussion_r4479156406
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/query/continuous/CacheContinuousQueryHandler.java:
##########
@@ -1259,6 +1256,45 @@ else if (!entry.isFiltered())
}
}
+ /**
+ * Converts the event for the listener on another node and sends it.
+ *
+ * @param cctx Cache context.
+ * @param evt Event.
+ * @param transformed Whether the query has a transformer.
+ * @param transVal Transformer result.
+ */
+ private void notifyRemoteListener(GridCacheContext<K, V> cctx,
CacheContinuousQueryEvent<K, V> evt,
+ boolean transformed, @Nullable Object transVal) {
+ try {
+ CacheContinuousQueryEntry entry = evt.entry();
+
+ if (!entry.isFiltered()) {
+ if (transformed)
+ entry = transformToEntry(transVal, evt);
+
+ prepareEntry(cctx, nodeId, entry);
+ }
+
+ Object entryOrList = handleEntry(cctx, entry);
+
+ if (entryOrList != null) {
+ if (log.isDebugEnabled())
+ log.debug("Send the following event to listener: " +
entryOrList);
+
+ ctx.continuous().addNotification(nodeId, routineId,
entryOrList, topic, sync, true);
+ }
+ }
+ catch (ClusterTopologyCheckedException ex) {
+ if (log.isDebugEnabled())
+ log.debug("Failed to send event notification to node, node
left cluster " +
+ "[node=" + nodeId + ", err=" + ex + ']');
+ }
+ catch (IgniteCheckedException ex) {
Review Comment:
runtime error currently will be silently ignored, can you catch
**Exception** here ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
