tkalkirill commented on code in PR #13737:
URL: https://github.com/apache/ignite/pull/13737#discussion_r4489022629


##########
modules/core/src/test/java/org/apache/ignite/internal/processors/cache/binary/IgniteBinaryTxPutAfterInvokeSelfTest.java:
##########
@@ -0,0 +1,95 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.processors.cache.binary;
+
+import javax.cache.CacheException;
+import javax.cache.processor.EntryProcessor;
+import javax.cache.processor.EntryProcessorException;
+import javax.cache.processor.MutableEntry;
+import org.apache.ignite.Ignite;
+import org.apache.ignite.IgniteCache;
+import org.apache.ignite.binary.BinaryObject;
+import org.apache.ignite.binary.BinaryObjectBuilder;
+import org.apache.ignite.cache.CacheAtomicityMode;
+import org.apache.ignite.configuration.CacheConfiguration;
+import org.apache.ignite.testframework.GridTestUtils;
+import org.apache.ignite.testframework.junits.common.GridCommonAbstractTest;
+import org.apache.ignite.transactions.Transaction;
+import org.junit.Test;
+
+/**
+ * Tests that an error thrown on a cache update in a transaction, that follows 
an {@code EntryProcessor}
+ * invocation for the same key, is not masked by a key deserialization failure 
when the key is a binary
+ * object without a Java class.
+ */
+public class IgniteBinaryTxPutAfterInvokeSelfTest extends 
GridCommonAbstractTest {

Review Comment:
   We need to add a test class to class 
org.apache.ignite.testsuites.IgniteBinaryObjectsTestSuite.
   Place it at the end of the list and add a trailing comma to minimize 
potential merge conflicts. 
   
   Something like this:
   ```
       RawBinaryObjectExtractorTest.class,
       CrossObjectReferenceSerializationTest.class,
   
       ThreadLocalAllocatorChunkShrinkTest.class,
   
       IgniteBinaryTxPutAfterInvokeSelfTest.class,
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to