zstan commented on code in PR #13745:
URL: https://github.com/apache/ignite/pull/13745#discussion_r4492341246


##########
modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/H2QueryInfo.java:
##########
@@ -76,6 +77,9 @@ public class H2QueryInfo implements TrackableQuery {
     /** Query initiator ID. */
     private final String initiatorId;
 
+    /** Query parameters. */
+    private final Object[] params;

Review Comment:
   ```suggestion
       private final @Nullable Object[] params;
   ```



##########
modules/calcite/src/test/java/org/apache/ignite/internal/processors/query/calcite/integration/SqlDiagnosticIntegrationTest.java:
##########
@@ -1040,6 +1040,39 @@ public void testSqlFieldsQueryWithInitiatorId() throws 
Exception {
         assertTrue(logLsnr.check(1000));
     }
 
+    /** Checks that query parameters are printed in the long query warning 
only when sensitive data is allowed. */
+    @Test
+    public void testLongQueryParametersInLog() throws Exception {
+        IgniteCache<Long, Long> cache = prepareTestCache(grid(0));
+
+        long arg = LONG_QRY_TIMEOUT + 1;

Review Comment:
   I understand that other tests are also used the same approach (I mean: 
LONG_QRY_TIMEOUT +1 ) but I`d suggest to use LONG_QRY_TIMEOUT + 
LONG_QRY_TIMEOUT / 2 for this and H2 related test to reduce flaky runs



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to