Copilot commented on code in PR #13741: URL: https://github.com/apache/ignite/pull/13741#discussion_r4443926986
########## docs/_docs/persistence/native-persistence.adoc: ########## @@ -207,11 +213,21 @@ If a node is terminated abruptly during update operations, it is very likely tha === WAL Archive -The WAL archive is used to store WAL segments that may be needed to recover the node after a crash. The number of segments kept in the archive is such that the total size of all segments does not exceed the specified size of the WAL archive. +The WAL archive is used to store WAL segments that may be needed to recover the node after a crash. The number of segments kept in the archive is defined by the cleanup rules described below. + +By default, the maximum size of the WAL archive is `maxWalArchiveSize`, whose default value is 1 GiB. You can change that value in the <<Configuration Properties,configuration>>. Review Comment: The cross-reference `<<Configuration Properties,configuration>>` is likely to be unresolved unless the target section’s autogenerated ID is exactly `Configuration Properties`. Prefer referencing the section ID (typically lowercase with hyphens), e.g. `<<configuration-properties,configuration>>`, or add an explicit anchor to the target section and reference that anchor. ########## docs/_docs/setup.adoc: ########## @@ -143,6 +143,11 @@ include::code-snippets/cpp/src/setting_work_directory.cpp[tag=setting-work-direc ---- -- +The work directory contains binary metadata and marshaller mappings, so treat it as durable storage even when data and WAL are configured elsewhere. +Keep the work directory on persistent storage with enough free space. +Store logs on a separate file system. +See link:server-node-file-system-layout[Server Node File System Layout] for the recommended disk placement of the work directory, data, WAL, logs, and diagnostic files. Review Comment: The setup page now repeats log-placement guidance in multiple places (and logging.adoc also covers it in depth). To reduce duplication and keep future edits consistent, consider shortening this block to focus on the work directory (durability + free space) and rely on the link to the new ‘Server Node File System Layout’ (and/or the logging page) for log-placement recommendations. ########## docs/_docs/logging.adoc: ########## @@ -44,7 +44,11 @@ work/log` == Default Logging By default, Ignite uses the java.util.logging (JUL) framework. If you start Ignite using the `ignite.sh|bat` script from the distribution package, Ignite uses `$IGNITE_HOME/config/java.util.logging.properties` as the default logging configuration file and outputs all messages to log files in the `$IGNITE_HOME/work/log` directory. -You can override the default logging directory by specifying the `IGNITE_LOG_DIR` system property. +You can override the default logging directory by setting the `IGNITE_LOG_DIR` environment variable of the node process. This variable is read once at startup and applies to the built-in JUL logger only; if you use Log4j2, change the file paths in the Log4j2 configuration instead. Review Comment: This change flips `IGNITE_LOG_DIR` from being described as a system property to an environment variable. If Ignite supports one (or both), the docs should match the actual resolution order/behavior to avoid misconfiguration. Consider documenting both forms explicitly (and which takes precedence), or keep it consistent with the mechanism Ignite actually reads at runtime. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
