anton-vinogradov commented on PR #13801:
URL: https://github.com/apache/ignite/pull/13801#issuecomment-6765945136

   I extended 
[IGNITE-29252](https://issues.apache.org/jira/browse/IGNITE-29252): the picked 
cipher suite can be unusable in more cases than the TLS 1.3 defaults on 
Corretto 17. I ran the whole class on Corretto 17.0.15 with and without 
`-Djdk.tls.client.protocols=TLSv1.2`, and with and without NULL suites allowed.
   
   - TeamCity passes on master because its JDK allows NULL suites and the 
helper picks `TLS_ECDHE_RSA_WITH_NULL_SHA`. The JDBC build does not set 
`jdk.tls.client.protocols`, so the PR description needs a fix here.
   - With NULL suites allowed, the candidates also include 
`TLS_ECDHE_ECDSA_WITH_NULL_SHA`. Its handshake with the RSA key in `server.jks` 
fails, so TeamCity passes only because of the `HashSet` order.
   - When no suitable suite exists, the assumption also skips the DES check in 
`testDisabledCustomCipher`, although that check does not need the suite. Please 
move it out of the skipped part, for example into its own test.
   
   The ticket title changed too, so please rename the PR to match it. The 
filter change is in the comment on line 785.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to