nizhikov commented on code in PR #13785: URL: https://github.com/apache/ignite/pull/13785#discussion_r4535273531
########## modules/core/src/main/java/org/apache/ignite/internal/management/ssl/SslReloadTask.java: ########## @@ -0,0 +1,219 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.management.ssl; + +import java.util.ArrayList; +import java.util.Collection; +import java.util.Collections; +import java.util.HashMap; +import java.util.IdentityHashMap; +import java.util.List; +import java.util.Map; +import java.util.Set; +import java.util.UUID; +import javax.cache.configuration.Factory; +import javax.net.ssl.SSLContext; +import org.apache.ignite.IgniteException; +import org.apache.ignite.cluster.ClusterNode; +import org.apache.ignite.cluster.ClusterTopologyException; +import org.apache.ignite.compute.ComputeJob; +import org.apache.ignite.compute.ComputeJobResult; +import org.apache.ignite.internal.Order; +import org.apache.ignite.internal.dto.IgniteDataTransferObject; +import org.apache.ignite.internal.management.api.NoArg; +import org.apache.ignite.internal.processors.task.GridInternal; +import org.apache.ignite.internal.util.typedef.X; +import org.apache.ignite.internal.visor.VisorJob; +import org.apache.ignite.internal.visor.VisorMultiNodeTask; +import org.apache.ignite.internal.visor.VisorTaskArgument; +import org.apache.ignite.plugin.security.SecuritySubject; +import org.apache.ignite.ssl.AbstractSslContextFactory; + +import static java.util.stream.Collectors.joining; + +/** */ +@GridInternal +public class SslReloadTask extends VisorMultiNodeTask<NoArg, String, SslReloadTask.SslReloadJobResult> { + /** */ + private static final long serialVersionUID = 0; + + /** */ + private Collection<UUID> targetNodes; + + /** {@inheritDoc} */ + @Override protected Map<? extends ComputeJob, ClusterNode> map0(List<ClusterNode> subgrid, VisorTaskArgument<NoArg> arg) { + targetNodes = arg.getNodes(); + + Map<? extends ComputeJob, ClusterNode> jobs = super.map0(subgrid, arg); + + if (jobs.isEmpty()) + throw new IgniteException(targetNodes.stream().map(id -> id + ": left the topology").collect(joining("\n"))); + + return jobs; + } + + /** {@inheritDoc} */ + @Override protected VisorJob<NoArg, SslReloadJobResult> job(NoArg arg) { + return new SslReloadJob(arg, debug); + } + + /** {@inheritDoc} */ + @Override protected String reduce0(List<ComputeJobResult> results) { + Map<UUID, ComputeJobResult> nodeResults = new HashMap<>(); + + for (ComputeJobResult res : results) + nodeResults.put(res.getNode().id(), res); + + List<String> reports = new ArrayList<>(); + boolean failed = false; + + for (UUID id : targetNodes) { + ComputeJobResult res = nodeResults.get(id); + + if (res == null || X.hasCause(res.getException(), ClusterTopologyException.class)) { + reports.add(id + ": left the topology"); + failed = true; + } + else if (res.getException() != null) { + reports.add(id + ": failed: " + errorMessage(res.getException())); + failed = true; + } + else { + SslReloadJobResult nodeRes = res.getData(); + + reports.add(nodeRes.report); + failed |= nodeRes.failed; + } + } + + String report = String.join("\n", reports); + + if (failed) + throw new IgniteException(report); + + return report; + } + + /** */ + private static String errorMessage(Throwable err) { + return err.getMessage() == null ? err.getClass().getName() : err.getMessage(); + } + + /** */ + private static class SslReloadJob extends VisorJob<NoArg, SslReloadJobResult> { + /** */ + private static final long serialVersionUID = 0; + + /** */ + private SslReloadJob(NoArg arg, boolean debug) { + super(arg, debug); + } + + /** {@inheritDoc} */ + @Override protected SslReloadJobResult run(NoArg arg) { + Map<String, Factory<SSLContext>> factories = ignite.context().ssl().factories(); + UUID nodeId = ignite.localNode().id(); + String initiator = ""; + + if (ignite.context().security().enabled()) { + SecuritySubject subj = ignite.context().security().securityContext().subject(); + + initiator = " [initiator=" + subj.login() + ", subjectId=" + subj.id() + ']'; + } + + if (factories.isEmpty()) { + String report = nodeId + ": no TCP transports started with TLS"; + + ignite.log().info("TLS reload: " + report + initiator); + + return new SslReloadJobResult(report, false); + } + + Set<Factory<SSLContext>> processed = Collections.newSetFromMap(new IdentityHashMap<>()); + List<String> reports = new ArrayList<>(); + boolean failed = false; + + for (Factory<SSLContext> factory : factories.values()) { + if (!processed.add(factory)) + continue; + + String transports = factories.entrySet().stream() + .filter(entry -> entry.getValue() == factory) + .map(Map.Entry::getKey) + .collect(joining(", ")); + + String outcome; + boolean factoryFailed = false; + Exception err = null; + + if (!(factory instanceof AbstractSslContextFactory)) { Review Comment: Let's check that all factories are `AbstractSslContextFactory` and throw if not before refresh anything. Like: ``` for (Factory<SSLContext> factory : factories.values()) { if (!(factory instanceof AbstractSslContextFactory)) throw new IgniteException("Factory: " + factory.getClass().getName() + " not support reload"); } for (Factory<SSLContext> factory : factories.values()) { ((AbstractSslContextFactory)factory).init(); } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
