NSAmelchev opened a new pull request, #13821: URL: https://github.com/apache/ignite/pull/13821
Several fields and flags of transaction and get messages are filled in and sent, but no node reads them, including nodes of the 2.19 release branch: - `GridDistributedTxFinishRequest#threadId` and `GridNearTxFinishResponse#nearThreadId`: their only consumer, `GridCacheTxFinishSync`, was removed in IGNITE-5714; - `GridDistributedTxFinishRequest#taskNameHash`: its getter was removed as unused in IGNITE-27942, the field stayed; - `GridDhtTxFinishRequest#nearNodeId`; - `GridNearGetRequest#ver` and `GridNearGetResponse#ver`: the primary node only echoes the request version back, and the near node ignores it; - the recovery flag of `GridNearTxPrepareRequest`: its getter was removed as unused in IGNITE-27942, but the flag is still computed and set; - the need-entry-info flag of `GridNearSingleGetRequest`: it has never been set since it was introduced in 2015, so the branch that handles it on the primary node is dead. The fields are deprecated with `@Order(deprecatedBy = ...)` and are no longer populated. In a mixed cluster they are sent with default values, which older nodes ignore as well; after the rolling upgrade is finalized they are not sent at all. A feature can gate only one field of a message hierarchy, so the three fields of `GridDhtTxFinishRequest` take three new core features, and the other fields reuse the first one. The flag masks are kept as reserved, because older nodes still set or read these bits. `IgniteTxLocalState#recovery()` loses its last caller and is removed. `GridCommandHandlerTest#testKillHangingRemoteTransactions` found the blocked finish request by its near node ID; it now matches the request by the version of the client's transaction on the primary node. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
