NSAmelchev commented on PR #372:
URL: 
https://github.com/apache/ignite-extensions/pull/372#issuecomment-6983365870

   **1. `since(VER_2_18_0)` (line 104)**
   
   It yields a single version, 2.18.0, which is serialization-compatible with 
master anyway. I reverted the fix locally (`CdcEventInputStream` -> 
`ObjectInputStream` in `KafkaToIgniteCdcStreamerApplier#deserialize`) and the 
test still passes. The ticket is about 2.17, so I'd expect 2.17.0 to be here.
   
   **2. Just switching to `since(VER_2_17_0)` doesn't work**
   
   The test fails for 2.17.0 even with the fix. The old JVM runs the current 
cdc-ext, and `KafkaToIgniteMetrics` uses a `StandaloneGridKernalContext` 
constructor that doesn't exist in 2.17:
   
   ```
   Exception in thread "kafka-to-ignite-dest-source" 
java.lang.NoSuchMethodError:
     'void 
org.apache.ignite.internal.processors.cache.persistence.wal.reader.StandaloneGridKernalContext.<init>(
         org.apache.ignite.IgniteLogger,
         org.apache.ignite.internal.processors.compress.CompressionProcessor,
         
org.apache.ignite.internal.processors.cache.persistence.filename.NodeFileTree)'
       at 
org.apache.ignite.cdc.kafka.KafkaToIgniteMetrics.initStandaloneMetricsKernal(KafkaToIgniteMetrics.java:137)
   ```
   
   The error stays in a daemon thread of the remote JVM, so the test just fails 
after 60 seconds with "Data must be replicated to both clusters".
   
   Proposal: use `since(VER_2_17_0)`, and for 2.17.0 don't start 
`KafkaToIgniteClientCdcStreamer` on the old side and check the old -> current 
direction only (an alternative assert for this version, similar to 
`incompatible()` in `CdcEventSerializationCompatibilityTest`). For 2.18.0+ keep 
the test as is.
   
   I checked this direction locally for 2.17.0: it passes with the fix and 
fails without it, with `InvalidClassException: 
org.apache.ignite.internal.binary.BinaryObjectExImpl; local class incompatible` 
in the applier of the current version.
   
   **3. Javadoc (line 60)**
   
   "Clusters of different Ignite versions" is a bit misleading: both sides run 
the current cdc-ext, the old side is an old ignite-core with the current 
cdc-ext. Worth saying explicitly.
   
   **Nits**
   
   - `kafkaProperties(kafkaAddrs, grpSuffix)`: the appliers use `assign`, and 
`CdcKafkaReplicationAbstractTest` uses the same group for both directions, so 
the parameter looks unnecessary.
   - `assertEquals(2 * KEYS_CNT, ...size())` (lines 189-190): all the keys are 
already checked by value above.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to