[ 
https://issues.apache.org/jira/browse/IOTDB-1459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17382693#comment-17382693
 ] 

Eric Pai commented on IOTDB-1459:
---------------------------------

In my opinion, there'e not any confusion in using `IT` or `ITcase` and these 
names are both OK according to maven official documentation. Unifyng their 
names with the configuration in pom.xml is the only traget we focus.

I have submitted a pull request [https://github.com/apache/iotdb/pull/3588] to 
do this. I prefer to use `IT` because it's a little shorter :D and with less 
code changes.

 

 

> Unified the naming of test class
> --------------------------------
>
>                 Key: IOTDB-1459
>                 URL: https://issues.apache.org/jira/browse/IOTDB-1459
>             Project: Apache IoTDB
>          Issue Type: Sub-task
>          Components: Test
>            Reporter: sunjincheng
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 0.13.0
>
>
> At present, the naming of some test classes is not uniform,such as, `IT` vs 
> `ITCase`, e.g.:
> 1. 
> https://github.com/apache/iotdb/tree/master/server/src/test/java/org/apache/iotdb/db/integration
>  (end with `IT`).
> 2. 
> https://github.com/apache/iotdb/tree/master/flink-tsfile-connector/src/test/java/org/apache/iotdb/flink/tsfile
>   (end with `ITCase`).
> BTW: The test issue is also involved here, as follows:
> - 
> https://github.com/apache/iotdb/blob/9bbea3deee0ad7a382fb509d905a79ce44f4208d/pom.xml#L909
> - 
> https://github.com/apache/iotdb/blob/9bbea3deee0ad7a382fb509d905a79ce44f4208d/pom.xml#L922
> The open question is:
>  I am not pretty sure about which one is best of `Test` vs `TaseCase` and 
> `IT` vs `ITCase` ,but we should chose one uniform naming format. 
> Refer to other communities: 
> [1] Flink(xxITCase): 
> https://github.com/apache/flink/tree/master/flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/runtime/stream/table
> [2] Spark(xxxSuite): 
> https://github.com/apache/spark/tree/master/sql/core/src/test/scala/org/apache/spark/sql
> For me, there are not the best one, only the most suitable, and the choice of 
> our iotdb community.  What's your thoughts. :)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to