[
https://issues.apache.org/jira/browse/IOTDB-5649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
LiYuheng reassigned IOTDB-5649:
-------------------------------
Assignee: LiYuheng (was: Minghui Liu)
> Refactor ExpressionAnalyzer using visitor pattern
> -------------------------------------------------
>
> Key: IOTDB-5649
> URL: https://issues.apache.org/jira/browse/IOTDB-5649
> Project: Apache IoTDB
> Issue Type: Improvement
> Reporter: Minghui Liu
> Assignee: LiYuheng
> Priority: Major
> Labels: pull-request-available
> Fix For: master branch
>
>
> ExpressionAnalyzer is the class in charge of handling expressions.
> Each method in this class has different ability, such as
> searchSourceExpressions() finds out which sources the expression contains,
> removeWildcardInExpression() remove * from expression, and so on.
> There were some redundant logic in ExpressionAnalyzer's methods. To make it
> easier to add new kinds of expressions, it's necessary to simplify.
> After analyze the similarity between these methods, I believe the visitor
> pattern is a good way to make it simple. The same logic can be contained in
> superclass-visitor, and the difference can be implemented by
> subclass-visitor's override.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
