jt2594838 commented on code in PR #111:
URL: https://github.com/apache/iotdb-client-go/pull/111#discussion_r1872746404
##########
client/session.go:
##########
@@ -1009,13 +1043,35 @@ func valuesToBytes(dataTypes []TSDataType, values
[]interface{}) ([]byte, error)
return buff.Bytes(), nil
}
+func (s *Session) insertRelationalTablet(tablet *Tablet) (r *common.TSStatus,
err error) {
+ if tablet.Len() == 0 {
+ return nil, nil
+ }
Review Comment:
Maybe we should return OK or an error? It seems confusing if both are nil.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
