HTHou opened a new pull request, #151: URL: https://github.com/apache/iotdb-client-go/pull/151
This pull request refactors the `Session` methods in `client/session.go` to standardize error handling and simplify method signatures. The main change is that several methods which previously returned both a status and an error now return only an error, with status verification handled internally. This makes the API easier to use and less error-prone for clients. **API simplification and error handling improvements:** * Changed multiple methods (such as `SetStorageGroup`, `DeleteStorageGroup`, `DeleteStorageGroups`, `CreateTimeseries`, `CreateAlignedTimeseries`, `CreateMultiTimeseries`, `DeleteTimeseries`, `DeleteData`, `InsertStringRecord`, `SetTimeZone`, `ExecuteNonQueryStatement`, `InsertRecord`, `InsertAlignedRecord`, `InsertRecordsOfOneDevice`, `InsertAlignedRecordsOfOneDevice`, `InsertRecords`, and `InsertAlignedRecords`) to return only an `error` instead of both a status and an error. Status checking is now done internally using `VerifySuccess`. [[1]](diffhunk://#diff-ca9d62a3432c6d2c68d9d2010a73f0cc725bd61952119de44f9428f4c49b00ebL231-R241) [[2]](diffhunk://#diff-ca9d62a3432c6d2c68d9d2010a73f0cc725bd61952119de44f9428f4c49b00ebL248-R261) [[3]](diffhunk://#diff-ca9d62a3432c6d2c68d9d2010a73f0cc725bd61952119de44f9428f4c49b00ebL265-R281) [[4]](diffhunk://#diff-ca9d62a3432c6d2c68d9d2010a73f0cc725bd61952119de44f9428f4c49b00ebL285-R294) [[5]](diffhunk://#diff-ca9d62a3432c6d2c68d9d2010a73f0cc725 bd61952119de44f9428f4c49b00ebL297-R309) [[6]](diffhunk://#diff-ca9d62a3432c6d2c68d9d2010a73f0cc725bd61952119de44f9428f4c49b00ebL312-R324) [[7]](diffhunk://#diff-ca9d62a3432c6d2c68d9d2010a73f0cc725bd61952119de44f9428f4c49b00ebL344-R359) [[8]](diffhunk://#diff-ca9d62a3432c6d2c68d9d2010a73f0cc725bd61952119de44f9428f4c49b00ebL357-R372) [[9]](diffhunk://#diff-ca9d62a3432c6d2c68d9d2010a73f0cc725bd61952119de44f9428f4c49b00ebL377-R392) [[10]](diffhunk://#diff-ca9d62a3432c6d2c68d9d2010a73f0cc725bd61952119de44f9428f4c49b00ebL386-R404) [[11]](diffhunk://#diff-ca9d62a3432c6d2c68d9d2010a73f0cc725bd61952119de44f9428f4c49b00ebL396-R424) [[12]](diffhunk://#diff-ca9d62a3432c6d2c68d9d2010a73f0cc725bd61952119de44f9428f4c49b00ebL415-R448) [[13]](diffhunk://#diff-ca9d62a3432c6d2c68d9d2010a73f0cc725bd61952119de44f9428f4c49b00ebL437-R476) [[14]](diffhunk://#diff-ca9d62a3432c6d2c68d9d2010a73f0cc725bd61952119de44f9428f4c49b00ebL460-R494) [[15]](diffhunk://#diff-ca9d62a3432c6d2c68d9d2010a73f0cc725bd61952119d e44f9428f4c49b00ebL494-R524) [[16]](diffhunk://#diff-ca9d62a3432c6d2c68d9d2010a73f0cc725bd61952119de44f9428f4c49b00ebR540-R546) [[17]](diffhunk://#diff-ca9d62a3432c6d2c68d9d2010a73f0cc725bd61952119de44f9428f4c49b00ebL651-R688) [[18]](diffhunk://#diff-ca9d62a3432c6d2c68d9d2010a73f0cc725bd61952119de44f9428f4c49b00ebL665-R708) [[19]](diffhunk://#diff-ca9d62a3432c6d2c68d9d2010a73f0cc725bd61952119de44f9428f4c49b00ebL682-R720) [[20]](diffhunk://#diff-ca9d62a3432c6d2c68d9d2010a73f0cc725bd61952119de44f9428f4c49b00ebL712-R753) [[21]](diffhunk://#diff-ca9d62a3432c6d2c68d9d2010a73f0cc725bd61952119de44f9428f4c49b00ebR765-R769) [[22]](diffhunk://#diff-ca9d62a3432c6d2c68d9d2010a73f0cc725bd61952119de44f9428f4c49b00ebL742-R781) [[23]](diffhunk://#diff-ca9d62a3432c6d2c68d9d2010a73f0cc725bd61952119de44f9428f4c49b00ebL751-R799) [[24]](diffhunk://#diff-ca9d62a3432c6d2c68d9d2010a73f0cc725bd61952119de44f9428f4c49b00ebR811-R815) [[25]](diffhunk://#diff-ca9d62a3432c6d2c68d9d2010a73f0cc725bd61952119de44f942 8f4c49b00ebL785-R828) [[26]](diffhunk://#diff-ca9d62a3432c6d2c68d9d2010a73f0cc725bd61952119de44f9428f4c49b00ebL794-R840) [[27]](diffhunk://#diff-ca9d62a3432c6d2c68d9d2010a73f0cc725bd61952119de44f9428f4c49b00ebL811-R893) **Internal logic and consistency improvements:** * Updated all affected methods to call `VerifySuccess` after RPC calls and to return early if an error is encountered, ensuring consistent error propagation and reducing code duplication. [[1]](diffhunk://#diff-ca9d62a3432c6d2c68d9d2010a73f0cc725bd61952119de44f9428f4c49b00ebL231-R241) [[2]](diffhunk://#diff-ca9d62a3432c6d2c68d9d2010a73f0cc725bd61952119de44f9428f4c49b00ebL248-R261) [[3]](diffhunk://#diff-ca9d62a3432c6d2c68d9d2010a73f0cc725bd61952119de44f9428f4c49b00ebL265-R281) [[4]](diffhunk://#diff-ca9d62a3432c6d2c68d9d2010a73f0cc725bd61952119de44f9428f4c49b00ebL285-R294) [[5]](diffhunk://#diff-ca9d62a3432c6d2c68d9d2010a73f0cc725bd61952119de44f9428f4c49b00ebL297-R309) [[6]](diffhunk://#diff-ca9d62a3432c6d2c68d9d2010a73f0cc725bd61952119de44f9428f4c49b00ebL312-R324) [[7]](diffhunk://#diff-ca9d62a3432c6d2c68d9d2010a73f0cc725bd61952119de44f9428f4c49b00ebL344-R359) [[8]](diffhunk://#diff-ca9d62a3432c6d2c68d9d2010a73f0cc725bd61952119de44f9428f4c49b00ebL357-R372) [[9]](diffhunk://#diff- ca9d62a3432c6d2c68d9d2010a73f0cc725bd61952119de44f9428f4c49b00ebL377-R392) [[10]](diffhunk://#diff-ca9d62a3432c6d2c68d9d2010a73f0cc725bd61952119de44f9428f4c49b00ebL386-R404) [[11]](diffhunk://#diff-ca9d62a3432c6d2c68d9d2010a73f0cc725bd61952119de44f9428f4c49b00ebL396-R424) [[12]](diffhunk://#diff-ca9d62a3432c6d2c68d9d2010a73f0cc725bd61952119de44f9428f4c49b00ebL415-R448) [[13]](diffhunk://#diff-ca9d62a3432c6d2c68d9d2010a73f0cc725bd61952119de44f9428f4c49b00ebL437-R476) [[14]](diffhunk://#diff-ca9d62a3432c6d2c68d9d2010a73f0cc725bd61952119de44f9428f4c49b00ebL460-R494) [[15]](diffhunk://#diff-ca9d62a3432c6d2c68d9d2010a73f0cc725bd61952119de44f9428f4c49b00ebL494-R524) [[16]](diffhunk://#diff-ca9d62a3432c6d2c68d9d2010a73f0cc725bd61952119de44f9428f4c49b00ebR540-R546) [[17]](diffhunk://#diff-ca9d62a3432c6d2c68d9d2010a73f0cc725bd61952119de44f9428f4c49b00ebL651-R688) [[18]](diffhunk://#diff-ca9d62a3432c6d2c68d9d2010a73f0cc725bd61952119de44f9428f4c49b00ebL665-R708) [[19]](diffhunk://#diff-ca9d62a 3432c6d2c68d9d2010a73f0cc725bd61952119de44f9428f4c49b00ebL682-R720) [[20]](diffhunk://#diff-ca9d62a3432c6d2c68d9d2010a73f0cc725bd61952119de44f9428f4c49b00ebL712-R753) [[21]](diffhunk://#diff-ca9d62a3432c6d2c68d9d2010a73f0cc725bd61952119de44f9428f4c49b00ebR765-R769) [[22]](diffhunk://#diff-ca9d62a3432c6d2c68d9d2010a73f0cc725bd61952119de44f9428f4c49b00ebL742-R781) [[23]](diffhunk://#diff-ca9d62a3432c6d2c68d9d2010a73f0cc725bd61952119de44f9428f4c49b00ebL751-R799) [[24]](diffhunk://#diff-ca9d62a3432c6d2c68d9d2010a73f0cc725bd61952119de44f9428f4c49b00ebR811-R815) [[25]](diffhunk://#diff-ca9d62a3432c6d2c68d9d2010a73f0cc725bd61952119de44f9428f4c49b00ebL785-R828) [[26]](diffhunk://#diff-ca9d62a3432c6d2c68d9d2010a73f0cc725bd61952119de44f9428f4c49b00ebL794-R840) [[27]](diffhunk://#diff-ca9d62a3432c6d2c68d9d2010a73f0cc725bd61952119de44f9428f4c49b00ebL811-R893) These changes make the session API cleaner and help prevent misuse by encapsulating status verification and error handling within each method. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
