HTHou opened a new pull request, #74:
URL: https://github.com/apache/iotdb-bin-resources/pull/74

   ## Summary
   
   - Move the default `prebuilt.artifacts.dir` to `target/prebuilt-artifacts`.
   - Update the English and Chinese release instructions to download GitHub 
Actions artifacts under `target/`.
   - Remove the old top-level `iotdb-tools-thrift/prebuilt-artifacts/` ignore 
entry so accidental use of that path is visible in `git status`.
   
   ## Root Cause
   
   The previous instructions downloaded prebuilt platform zip files into 
`iotdb-tools-thrift/prebuilt-artifacts/`. The Apache parent source-release 
assembly scans the project directory and excludes `target/`, but it does not 
exclude that top-level temporary directory. As a result, the source release zip 
included all prebuilt binary zips.
   
   ## Validation
   
   - Ran `./mvnw clean`, then downloaded the workflow artifact to 
`target/prebuilt-artifacts` with `gh run download 27532371068 --repo 
apache/iotdb-bin-resources --name iotdb-tools-thrift-all-platforms --dir 
target/prebuilt-artifacts`.
   - Ran `./mvnw package -P apache-release,prebuilt-artifacts -Dgpg.skip=true` 
successfully.
   - Verified `target/iotdb-tools-thrift-0.23.0.0-source-release.zip` is 78,369 
bytes and contains no `prebuilt-artifacts`, `target/`, or nested zip entries.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to