HTHou commented on PR #168: URL: https://github.com/apache/iotdb-client-go/pull/168#issuecomment-5053536119
Non-blocking follow-up suggestion: `Tablet.SetTimestamp` still writes to `t.timestamps[rowIndex]` without validating `rowIndex`. For example, with a tablet created using `NewTablet(..., 1)`, calling `SetTimestamp(ts, 1)` panics with an index-out-of-range error because the only valid row index is `0`. It may be worth applying equivalent bounds handling for consistency with `SetValueAt` and `GetValueAt`. Since `SetTimestamp` currently has no error return, addressing this cleanly may require an API decision (or a separate PR). This does not block the current focused fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
