PDGGK commented on PR #169: URL: https://github.com/apache/iotdb-client-go/pull/169#issuecomment-5066411249
Thanks @HTHou — good point on the interface/method-value compatibility, and you're right that a v2 public API shouldn't change `SetTimestamp`'s signature. Adopted: `SetTimestamp` is left exactly as-is, and I added `SetTimestampAt(timestamp int64, rowIndex int) error` doing the bounds validation (returning `illegal argument rowIndex`, consistent with `SetValueAt`/`GetValueAt`). The PR is now purely additive. Happy to add a doc note steering callers to the checked API if you'd like. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
