Author: sebb
Date: Mon Jun 28 19:05:04 2010
New Revision: 958685

URL: http://svn.apache.org/viewvc?rev=958685&view=rev
Log:
Bug 48709 - TCP Sampler Config setting "classname" has no effect

Modified:
    
jakarta/jmeter/trunk/src/protocol/tcp/org/apache/jmeter/protocol/tcp/sampler/TCPSampler.java
    jakarta/jmeter/trunk/xdocs/changes.xml

Modified: 
jakarta/jmeter/trunk/src/protocol/tcp/org/apache/jmeter/protocol/tcp/sampler/TCPSampler.java
URL: 
http://svn.apache.org/viewvc/jakarta/jmeter/trunk/src/protocol/tcp/org/apache/jmeter/protocol/tcp/sampler/TCPSampler.java?rev=958685&r1=958684&r2=958685&view=diff
==============================================================================
--- 
jakarta/jmeter/trunk/src/protocol/tcp/org/apache/jmeter/protocol/tcp/sampler/TCPSampler.java
 (original)
+++ 
jakarta/jmeter/trunk/src/protocol/tcp/org/apache/jmeter/protocol/tcp/sampler/TCPSampler.java
 Mon Jun 28 19:05:04 2010
@@ -122,6 +122,8 @@ public class TCPSampler extends Abstract
     };
 
     private transient TCPClient protocolHandler;
+    
+    private transient boolean firstSample; // Are we processing the first 
sample?
 
     public TCPSampler() {
         log.debug("Created " + this); //$NON-NLS-1$
@@ -285,6 +287,10 @@ public class TCPSampler extends Abstract
 
     public SampleResult sample(Entry e)// Entry tends to be ignored ...
     {
+        if (firstSample) { // Do stuff we cannot do as part of threadStarted()
+            initSampling();
+            firstSample=false;
+        }
         log.debug(getLabel() + " " + getFilename() + " " + getUsername() + " " 
+ getPassword());
         SampleResult res = new SampleResult();
         boolean isSuccessful = false;
@@ -373,13 +379,18 @@ public class TCPSampler extends Abstract
 
     public void threadStarted() {
         log.debug("Thread Started"); //$NON-NLS-1$
+        firstSample = true;
+    }
+
+    // Cannot do this as part of threadStarted() because the Config elements 
have not been processed.
+    private void initSampling(){
         protocolHandler = getProtocol();
         log.debug("Using Protocol Handler: " +  //$NON-NLS-1$
                 (protocolHandler == null ? "NONE" : 
protocolHandler.getClass().getName())); //$NON-NLS-1$
         if (protocolHandler != null){
             protocolHandler.setupTest();
         }
-}
+    }
 
     private void closeSocket() {
         Map<String, Object> cp = tp.get();

Modified: jakarta/jmeter/trunk/xdocs/changes.xml
URL: 
http://svn.apache.org/viewvc/jakarta/jmeter/trunk/xdocs/changes.xml?rev=958685&r1=958684&r2=958685&view=diff
==============================================================================
--- jakarta/jmeter/trunk/xdocs/changes.xml (original)
+++ jakarta/jmeter/trunk/xdocs/changes.xml Mon Jun 28 19:05:04 2010
@@ -107,6 +107,7 @@ This does not affect existing test plans
 <li>Bug 49111 - "Message With ID Not Found" Error on JMS P2P sampler.</li>
 <li>Bug 47949 - JMS Subscriber never receives all the messages</li>
 <li>Bug 46142 - JMS Point-to-Point correlation problems</li>
+<li>Bug 48709 - TCP Sampler Config setting "classname" has no effect</li>
 </ul>
 
 <h3>Controllers</h3>



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to