Author: sebb
Date: Fri Dec 10 17:04:08 2010
New Revision: 1044437
URL: http://svn.apache.org/viewvc?rev=1044437&view=rev
Log:
Findbugs: comparators should be serializable
Modified:
jakarta/jmeter/trunk/src/core/org/apache/jmeter/gui/util/MenuFactory.java
jakarta/jmeter/trunk/src/jorphan/org/apache/jorphan/math/NumberComparator.java
Modified:
jakarta/jmeter/trunk/src/core/org/apache/jmeter/gui/util/MenuFactory.java
URL:
http://svn.apache.org/viewvc/jakarta/jmeter/trunk/src/core/org/apache/jmeter/gui/util/MenuFactory.java?rev=1044437&r1=1044436&r2=1044437&view=diff
==============================================================================
--- jakarta/jmeter/trunk/src/core/org/apache/jmeter/gui/util/MenuFactory.java
(original)
+++ jakarta/jmeter/trunk/src/core/org/apache/jmeter/gui/util/MenuFactory.java
Fri Dec 10 17:04:08 2010
@@ -20,6 +20,7 @@ package org.apache.jmeter.gui.util;
import java.awt.Component;
import java.io.IOException;
+import java.io.Serializable;
import java.util.Collection;
import java.util.Collections;
import java.util.Comparator;
@@ -644,10 +645,11 @@ public final class MenuFactory {
/**
* Menu sort helper class
*/
- private static class MenuInfoComparator implements Comparator<MenuInfo> {
- public int compare(MenuInfo o1, MenuInfo o2) {
- return o1.getLabel().compareTo(o2.getLabel());
-}
+ private static class MenuInfoComparator implements Comparator<MenuInfo>,
Serializable {
+ private static final long serialVersionUID = 1L;
+ public int compare(MenuInfo o1, MenuInfo o2) {
+ return o1.getLabel().compareTo(o2.getLabel());
+ }
}
/**
Modified:
jakarta/jmeter/trunk/src/jorphan/org/apache/jorphan/math/NumberComparator.java
URL:
http://svn.apache.org/viewvc/jakarta/jmeter/trunk/src/jorphan/org/apache/jorphan/math/NumberComparator.java?rev=1044437&r1=1044436&r2=1044437&view=diff
==============================================================================
---
jakarta/jmeter/trunk/src/jorphan/org/apache/jorphan/math/NumberComparator.java
(original)
+++
jakarta/jmeter/trunk/src/jorphan/org/apache/jorphan/math/NumberComparator.java
Fri Dec 10 17:04:08 2010
@@ -21,9 +21,12 @@
*/
package org.apache.jorphan.math;
+import java.io.Serializable;
import java.util.Comparator;
-public class NumberComparator implements Comparator<Number[]> {
+public class NumberComparator implements Comparator<Number[]>, Serializable {
+
+ private static final long serialVersionUID = 1L;
public NumberComparator() {
super();
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
