https://issues.apache.org/bugzilla/show_bug.cgi?id=50032
--- Comment #14 from Milamber <milam...@apache.org> 2011-09-17 15:06:22 UTC ---
Philippe, your patch don't respect code style used in JMeter.
== No good ==
}
finally
{
== Good ==
} finally {
==========
== No good ==
if(isReinitializingSubControllers)
{
isReinitializingSubControllers = false;
}
else
{
log.warn("Unsetting while flag is not true");
}
== Good ==
if (isReinitializingSubControllers) { // please note: one space
before left parenthesis
isReinitializingSubControllers = false;
} else {
log.warn("Unsetting while flag is not true");
}
=======
Comments on source code don't need have all characters in uppercase
=======
"@see" must follow by a classname, not a "ISSUE" keyword.
Please respect code style convention in JMeter for next submissions. Thanks.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@jakarta.apache.org
For additional commands, e-mail: notifications-h...@jakarta.apache.org
