https://issues.apache.org/bugzilla/show_bug.cgi?id=52033

Sebb <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |NEW

--- Comment #3 from Sebb <[email protected]> 2011-10-15 15:42:46 UTC ---
Thanks for the patch; unfortunately it does not apply cleanly to the code in
trunk.

Also, there are several instances of using @SuppressWarnings.
As far as possible we don't allow these.
The instance ArrayList fields in DefaultKeyStore should be local variables.
The mutable static caches in JsseSLManager are not thread-safe.

But we can fix these.

I'm more concerned about the use of the system property names
javax.net.ssl.keyStoreStartIndex and javax.net.ssl.keyStoreEndIndex.

Are these standard property names?
I could not find any reference to them.
If these are invented names, then they should not use the javax namespace.
Probably should be JMeter properties.

The proposal needs a bit more consideration.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to