chibenwa commented on a change in pull request #249: URL: https://github.com/apache/james-project/pull/249#discussion_r497312386
########## File path: examples/pom.xml ########## @@ -20,14 +20,11 @@ <project xmlns="http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd";> <modelVersion>4.0.0</modelVersion> - <parent> - <groupId>org.apache.james</groupId> - <artifactId>james-project</artifactId> - <version>3.6.0-SNAPSHOT</version> - </parent> + <groupId>org.apache.examples.james</groupId> Review comment: I'm unsure that the James project is allowed to publish JARs to maven central with a `org.apache.examples.` prefix. Can you check the Apache foundation policies regarding this? ########## File path: examples/pom.xml ########## @@ -36,4 +33,14 @@ <module>custom-mailets</module> </modules> -</project> \ No newline at end of file + <properties> + <james.groupId>org.apache.james</james.groupId> + <james.baseVersion>3.6.0-SNAPSHOT</james.baseVersion> Review comment: I understand the concerns however it likely makes the release process hard. How do we ensure the version use by the example matches the released version? How does it integrate with the maven-release plugin? I I was to tag a 3.6.0 tomorrow, I would likely forget that. Even if I don't forget, how do I ensure the released exemple JAR matches the 3.6.0 version? Would I have to do a pre-release commit switching it to the not yet released 3.6.0 - in which case the whole process might fail at publishing snapshots? Maybe a wiser value here would be : ``` <james.baseVersion>${project.version}</james.baseVersion> ``` That way as the version of the example and James are implicitly aliagned, the maven-release prompt will enable me to do the switch painlessly... ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
