aasaru commented on a change in pull request #249: URL: https://github.com/apache/james-project/pull/249#discussion_r498048212
########## File path: examples/pom.xml ########## @@ -20,14 +20,11 @@ <project xmlns="http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd";> <modelVersion>4.0.0</modelVersion> - <parent> - <groupId>org.apache.james</groupId> - <artifactId>james-project</artifactId> - <version>3.6.0-SNAPSHOT</version> - </parent> + <groupId>org.apache.examples.james</groupId> Review comment: After thinking about this I realised that if we have all example code under org.apache.james.examples then we cannot use package level access anywhere (as core james won't have the 'examples' part in the package name). Sorry for creating confusion - reverted back this part - let's stay to org.apache.james.examples ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
