jeantil commented on a change in pull request #293:
URL: https://github.com/apache/james-project/pull/293#discussion_r575312925
##########
File path:
server/mailet/mock-smtp-server/src/main/java/org/apache/james/mock/smtp/server/testing/MockSmtpServerExtension.java
##########
@@ -43,7 +44,8 @@
DockerMockSmtp() {
mockSmtpServer = DockerContainer.fromName(Images.MOCK_SMTP_SERVER)
- .withLogConsumer(outputFrame -> LOGGER.debug("MockSMTP: " +
outputFrame.getUtf8String()));
+ .withLogConsumer(outputFrame -> LOGGER.debug("MockSMTP: " +
outputFrame.getUtf8String()))
+ .waitingFor(Wait.forLogMessage(".*Mock SMTP server started.*",
1));
Review comment:
that's weird:
https://github.com/testcontainers/testcontainers-java/blob/17b4f6c136f6f2c7dc223bad407221f62a8f0088/core/src/main/java/org/testcontainers/containers/wait/strategy/HostPortWaitStrategy.java#L26
seems to use `getLivenessCheckPorts` (with an `s`) for the external checks and
https://github.com/testcontainers/testcontainers-java/blob/17b4f6c136f6f2c7dc223bad407221f62a8f0088/core/src/main/java/org/testcontainers/containers/wait/strategy/HostPortWaitStrategy.java#L35
uses `getExposedPorts` for the internal checks and before suggesting this I
checked that this was already the case in 1.15.1
I don't see how you could use the container if both ports are not exposed
since the tests call both the smtp and the http service ...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
