This is an automated email from the ASF dual-hosted git repository.

btellier pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/james-project.git

commit 96abdce032e6665b1fe32547ab77faff777c92b4
Author: Benoit Tellier <[email protected]>
AuthorDate: Wed Mar 24 15:28:32 2021 +0700

    JAMES-3432 Fix Download: Forbidden should mention download
---
 .../scala/org/apache/james/jmap/rfc8621/contract/DownloadContract.scala | 2 +-
 .../scala/org/apache/james/jmap/rfc8621/contract/UploadContract.scala   | 2 +-
 .../src/main/scala/org/apache/james/jmap/routes/DownloadRoutes.scala    | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git 
a/server/protocols/jmap-rfc-8621-integration-tests/jmap-rfc-8621-integration-tests-common/src/main/scala/org/apache/james/jmap/rfc8621/contract/DownloadContract.scala
 
b/server/protocols/jmap-rfc-8621-integration-tests/jmap-rfc-8621-integration-tests-common/src/main/scala/org/apache/james/jmap/rfc8621/contract/DownloadContract.scala
index 53ebd57..1c8c401 100644
--- 
a/server/protocols/jmap-rfc-8621-integration-tests/jmap-rfc-8621-integration-tests-common/src/main/scala/org/apache/james/jmap/rfc8621/contract/DownloadContract.scala
+++ 
b/server/protocols/jmap-rfc-8621-integration-tests/jmap-rfc-8621-integration-tests-common/src/main/scala/org/apache/james/jmap/rfc8621/contract/DownloadContract.scala
@@ -177,7 +177,7 @@ trait DownloadContract {
       .statusCode(SC_FORBIDDEN)
       .body("status", equalTo(403))
       .body("type", equalTo("about:blank"))
-      .body("detail", equalTo("You cannot upload in others accounts"))
+      .body("detail", equalTo("You cannot download in others accounts"))
   }
 
   @Test
diff --git 
a/server/protocols/jmap-rfc-8621-integration-tests/jmap-rfc-8621-integration-tests-common/src/main/scala/org/apache/james/jmap/rfc8621/contract/UploadContract.scala
 
b/server/protocols/jmap-rfc-8621-integration-tests/jmap-rfc-8621-integration-tests-common/src/main/scala/org/apache/james/jmap/rfc8621/contract/UploadContract.scala
index 2d5773f..758235d 100644
--- 
a/server/protocols/jmap-rfc-8621-integration-tests/jmap-rfc-8621-integration-tests-common/src/main/scala/org/apache/james/jmap/rfc8621/contract/UploadContract.scala
+++ 
b/server/protocols/jmap-rfc-8621-integration-tests/jmap-rfc-8621-integration-tests-common/src/main/scala/org/apache/james/jmap/rfc8621/contract/UploadContract.scala
@@ -127,7 +127,7 @@ trait UploadContract {
       .statusCode(SC_UNAUTHORIZED)
       .body("status", equalTo(401))
       .body("type", equalTo("about:blank"))
-      .body("detail", equalTo("No valid authentication methods provided"))
+      .body("detail", equalTo("You cannot download in others accounts"))
   }
 
   @Test
diff --git 
a/server/protocols/jmap-rfc-8621/src/main/scala/org/apache/james/jmap/routes/DownloadRoutes.scala
 
b/server/protocols/jmap-rfc-8621/src/main/scala/org/apache/james/jmap/routes/DownloadRoutes.scala
index 0deff91..7f817a2 100644
--- 
a/server/protocols/jmap-rfc-8621/src/main/scala/org/apache/james/jmap/routes/DownloadRoutes.scala
+++ 
b/server/protocols/jmap-rfc-8621/src/main/scala/org/apache/james/jmap/routes/DownloadRoutes.scala
@@ -221,7 +221,7 @@ class DownloadRoutes 
@Inject()(@Named(InjectionKeys.RFC_8621) val authenticator:
       .onErrorResume {
         case e: ForbiddenException =>
           respondDetails(response,
-            ProblemDetails(status = FORBIDDEN, detail = "You cannot upload in 
others accounts"),
+            ProblemDetails(status = FORBIDDEN, detail = "You cannot download 
in others accounts"),
             FORBIDDEN)
         case e: UnauthorizedException =>
           LOGGER.warn("Unauthorized", e)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to