quantranhong1999 commented on a change in pull request #346:
URL: https://github.com/apache/james-project/pull/346#discussion_r603791018
##########
File path:
server/data/data-jmap/src/test/java/org/apache/james/jmap/api/filtering/FilteringManagementContract.java
##########
@@ -66,7 +66,7 @@ default void listingRulesShouldThrowWhenNullUser(EventStore
eventStore) {
default void listingRulesShouldReturnDefinedRules(EventStore eventStore) {
FilteringManagement testee =
instantiateFilteringManagement(eventStore);
- Mono.from(testee.defineRulesForUser(USERNAME, RULE_1, RULE_2)).block();
+ Mono.from(testee.defineRulesForUser(USERNAME,
Optional.of(Version.INITIAL), RULE_1, RULE_2)).block();
Review comment:
```
public Rules listRules() {
return new Rules(state.rules,
history.getVersionAsJava().map(EventId::value).map(Version::new).orElse(Version.INITIAL));
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
