chibenwa commented on a change in pull request #351:
URL: https://github.com/apache/james-project/pull/351#discussion_r606191268
##########
File path:
server/protocols/jmap-rfc-8621/src/main/scala/org/apache/james/jmap/method/Method.scala
##########
@@ -83,13 +83,14 @@ trait MethodRequiringAccountId[REQUEST <: WithAccountId]
extends Method {
case e: IllegalArgumentException => SFlux.just[InvocationWithContext]
(InvocationWithContext(Invocation.error(ErrorCode.InvalidArguments,
e.getMessage, invocation.invocation.methodCallId),
invocation.processingContext))
case e: MailboxNotFoundException => SFlux.just[InvocationWithContext]
(InvocationWithContext(Invocation.error(ErrorCode.InvalidArguments,
e.getMessage, invocation.invocation.methodCallId),
invocation.processingContext))
case e: ChangeNotFoundException => SFlux.just[InvocationWithContext]
(InvocationWithContext(Invocation.error(ErrorCode.CannotCalculateChanges,
e.getMessage, invocation.invocation.methodCallId),
invocation.processingContext))
+ case e: RequestTooLargeException => SFlux.just[InvocationWithContext]
(InvocationWithContext(Invocation.error(ErrorCode.RequestTooLarge,
e.description, invocation.invocation.methodCallId),
invocation.processingContext))
case e: Throwable => SFlux.raiseError[InvocationWithContext] (e)
}
metricFactory.decoratePublisherWithTimerMetricLogP99(JMAP_RFC8621_PREFIX +
methodName.value, result)
}
- private def validateAccountId(accountId: AccountId, mailboxSession:
MailboxSession, sessionSupplier: SessionSupplier, invocation: Invocation):
Either[IllegalArgumentException, Session] =
Review comment:
This method can likely still be private.
Can you restore private readability?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
