chibenwa commented on a change in pull request #385:
URL: https://github.com/apache/james-project/pull/385#discussion_r615749835
##########
File path:
server/protocols/jmap-rfc-8621-integration-tests/jmap-rfc-8621-integration-tests-common/src/main/scala/org/apache/james/jmap/rfc8621/contract/MDNSendMethodContract.scala
##########
@@ -130,7 +130,7 @@ trait MDNSendMethodContract {
| "MDN/send",
| {
| "accountId": "$ANDRE_ACCOUNT_ID",
- | "identityId": "I64588216",
+ | "identityId": "$ANDRE_ACCOUNT_ID",
Review comment:
You do put an accountId in an identityId? These are not the same...
Edit: accountId and identityId happens to share the same format in our
implementation.
However we need 2 separate constant in our tests:
```
val ANDRE_ACCOUNT_ID: String =
"1e8584548eca20f26faf6becc1704a0f352839f12c208a47fbd486d60f491f7c"
val ANDRE_IDENTITY_ID: String =
"1e8584548eca20f26faf6becc1704a0f352839f12c208a47fbd486d60f491f7c"
```
And use
```
"accountId": "$ANDRE_ACCOUNT_ID",
"identityId": "$ANDRE_IDENTITY_ID",
````
here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
