chibenwa opened a new pull request #399:
URL: https://github.com/apache/james-project/pull/399


   I took time to port what we have regarding James packaging with James. 
Includes:
   
    - The CLI. Strategy is to add a runtime dependency and have a custom script.
    - Glowroot is bundled. Downloaded by a maven plugin, and combined with its 
configuration files before being added to the image.
    - extra java options are supported via an environment variable
    
   Let's review this one first, then I devote myself committing this for the 
other guice servers.
   
   The image size is slightly bigger (573 MB vs 383MB for the 3.6.0 memory 
docker image), it might be worth it to investigate where the extra size is 
coming from.
   
   I choose buildTar as a goal, but in the end dockerBuild goal might enable us 
 to run tests on top of the James docker images (what we used to call 
'deployment tests' to check image validity, as testing dependencies could (had) 
been hiding problems). Not docker users could then use `-Djib.skip` to not be 
impacted by this possible choice.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to