chibenwa commented on a change in pull request #400:
URL: https://github.com/apache/james-project/pull/400#discussion_r618868222
##########
File path: server/container/guice/cassandra-rabbitmq-guice/pom.xml
##########
@@ -156,6 +165,26 @@
<groupId>${james.groupId}</groupId>
<artifactId>james-server-guice-jmx</artifactId>
</dependency>
+ <dependency>
Review comment:
>Shouldn't these dependencies be in a common guice server definition ?
(by these dependencies I mean the ones that are not specific to a particular
storage technology.
I could decide to build a server without a given protocol (say JMAP, IMAP,
POP3) for instance, to build a pure MTA.
> I had a look and james-server-guice-common feels like a good candidate but
for some reason it pulls in inmemory implementations of some components such as
james-server-task-memory james-server-mailrepository-memory
Yes some cleanup still to be done, to be honnest.
We might have considered by the past that inMemory dependencies were light
with no extra external dependencies thus having them sneaking in was acceptable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
