chibenwa commented on a change in pull request #391:
URL: https://github.com/apache/james-project/pull/391#discussion_r629203941
##########
File path:
server/protocols/jmap-rfc-8621/src/main/scala/org/apache/james/jmap/change/StateChange.scala
##########
@@ -31,7 +31,7 @@ trait TypeName {
def asString(): String
def parse(string: String): Option[TypeName]
- def parseState(string: String): Either[IllegalArgumentException, State]
+ def parseState(string: String): Either[IllegalArgumentException, State] =
UuidState.parse(string)
Review comment:
No I think this change is a regression.
Less line of code is not always good: It is perfectly fine to have all
factories use 1 line to specify how they deserialise stuff explicitly...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
