Arsnael commented on pull request #446: URL: https://github.com/apache/james-project/pull/446#issuecomment-845822704
Your ThreadId is not equal to MessageId here. You just "implement" the MessageId interface in a complete different way that the mem and Cassandra implems. I' prettu sure if you write some quick tests and try to access it with your cast, it breaks? I don't think ThreadId should be implemented this way... Not sure what would be the best approach here. Maybe I would have just duplicated the MessageId code and renamed it ThreadId? And add a method to make ThreadId and MessageId conversions... but I'm not sure either... @chibenwa have a better idea? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
