jeantil commented on a change in pull request #476:
URL: https://github.com/apache/james-project/pull/476#discussion_r647485941
##########
File path:
mailbox/cassandra/src/main/java/org/apache/james/mailbox/cassandra/modules/CassandraMailboxModule.java
##########
@@ -42,7 +42,8 @@
.comment("Holds the mailboxes information.")
.options(options -> options
.caching(SchemaBuilder.KeyCaching.ALL,
-
SchemaBuilder.rows(CassandraConstants.DEFAULT_CACHED_ROW_PER_PARTITION)))
+
SchemaBuilder.rows(CassandraConstants.DEFAULT_CACHED_ROW_PER_PARTITION))
+ .compressionOptions(SchemaBuilder.lz4().withChunkLengthInKb(8)))
Review comment:
> TLDR: Using out of the box settings for compression on read heavy or
mixed workloads will almost certainly put unnecessary strain on your disk while
hurting your read performance.
I understand the logic behind the change, I challenge the arbitrary number
that was chosen :D
> Basically I tried a couple of values (4K, 8K, 16K, ...) and 8KB worked
well.
Aren't you worried that it is highly dependendant on the cassandra
infrastructure ? After all 640k is enough memory for everything ;p
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
