chibenwa commented on pull request #423: URL: https://github.com/apache/james-project/pull/423#issuecomment-858249015
> I have been thinking again... Do we need at all this PR? We need it to support clients that do not send websocket PINGs. This is the case EG of Gatling during performance tests. Now it this a real need? Or a corner case we can ignore because all real clients maintains PING? The question seems open to me. > It feels like reactor netty is managing that out of the box somehow, if you send it a ping, it answers a pong... The problem is when the client do not send PING. Eg Gatling. > I will check again tomorrow but I think it works that way... Regarding Gatling though, could not find a way to send a ping... But Didn't have much time to look, will dig more tomorrow. Maybe we could send a dummy echo method ? --------- Speaking with @tuanlc Javascript clients typically generate ping messages He had been solving similar problems with Gatling, he investigates :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
