chibenwa commented on a change in pull request #508:
URL: https://github.com/apache/james-project/pull/508#discussion_r663635870
##########
File path: server/apps/distributed-app/sample-configuration/rabbitmq.properties
##########
@@ -5,6 +5,10 @@
# Mandatory
uri=amqp://rabbitmq:5672
Review comment:
> Should we deprecate uri property?
If I can avoid a breaking change I'm happy.
I think URI is still easier to use for a single Rabbit set up.
You can further more pass extra info in it: VHost, username + password, SSL,
etc...
> When we declare hosts property, what is uri sense?
1. Host is optional
2. URI can be used for vhost, username, password, etc...
> Should we have only one property for endpoint declaration? IMO
We have to balance this with other goals too: how about avoiding to much
breaking changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
