Arsnael commented on a change in pull request #557:
URL: https://github.com/apache/james-project/pull/557#discussion_r678905924
##########
File path:
server/data/data-library/src/test/java/org/apache/james/user/lib/UsersRepositoryContract.java
##########
@@ -53,15 +54,12 @@
class UserRepositoryExtension implements BeforeEachCallback,
ParameterResolver {
- private static final boolean ENABLE_VIRTUAL_HOSTING = true;
- private static final boolean DISABLE_VIRTUAL_HOSTING =
!ENABLE_VIRTUAL_HOSTING;
Review comment:
We tend to use those variables. The thing here is if you take out those
variables, then you need to go to the constructor to see what is the boolean is
about. While with those, you don't need, you know precisely what they are for.
However, just realize it's for a test contract so I guess ok-ish (but would
not be for main code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
