chibenwa commented on a change in pull request #578:
URL: https://github.com/apache/james-project/pull/578#discussion_r688429413
##########
File path:
mailbox/cassandra/src/main/java/org/apache/james/mailbox/cassandra/mail/CassandraMessageIdDAO.java
##########
@@ -243,7 +244,15 @@ private PreparedStatement
prepareSelectUidRangeLimited(Session session) {
ComposedMessageId composedMessageId =
metadata.getComposedMessageId().getComposedMessageId();
Flags flags = metadata.getComposedMessageId().getFlags();
ThreadId threadId = metadata.getComposedMessageId().getThreadId();
- return cassandraAsyncExecutor.executeVoid(insert.bind()
+
+ BoundStatement boundStatement = insert.bind();
+ if (metadata.getComposedMessageId().getFlags().getUserFlags().length
== 0) {
+ boundStatement.unset(USER_FLAGS);
Review comment:
`boundStatement.setSet(USER_FLAGS, ImmutableSet.of());, It still good?`
No it is not: EMPTY collection DO insert tomstones....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
