chibenwa commented on a change in pull request #628:
URL: https://github.com/apache/james-project/pull/628#discussion_r698392978
##########
File path: server/apps/demo/Dockerfile
##########
@@ -15,7 +15,6 @@ RUN cp /root/wait-for-it/wait-for-it.sh
/usr/bin/wait-for-it.sh
Review comment:
When is a RUN command executed?
```
The RUN instruction will execute any commands in a new layer on top of the
current image and commit the results. The resulting committed image will be
used for the next step in the Dockerfile.
```
-> at image build time.
So all people using the same image would have the same keys.
All people download the demo image would have the same key.
This is not what we want.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
