[GitHub] [james-project] vttranlina commented on a change in pull request #654: Improvments for the README and Download page

[GitBox]

vttranlina commented on a change in pull request #654:
URL: https://github.com/apache/james-project/pull/654#discussion_r708907220



##########
File path: docs/modules/development/pages/deployment-tests.adoc
##########
@@ -0,0 +1,30 @@
+= How to run deployment Tests
+:navtitle: Deployment tests
+
+We wrote some MPT (James' Mail Protocols Tests subproject) deployment tests to 
validate a James
+deployment.
+
+It uses the External-James module, that uses environment variables to locate a 
remote
+IMAP server and run integration tests against it.
+
+For that, the target James Server needs to be configured with a domain domain 
and a user imapuser

Review comment:
       double `domain` 
   

##########
File path: docs/modules/development/pages/deployment-tests.adoc
##########
@@ -0,0 +1,30 @@
+= How to run deployment Tests
+:navtitle: Deployment tests
+
+We wrote some MPT (James' Mail Protocols Tests subproject) deployment tests to 
validate a James
+deployment.
+
+It uses the External-James module, that uses environment variables to locate a 
remote
+IMAP server and run integration tests against it.
+
+For that, the target James Server needs to be configured with a domain domain 
and a user imapuser
+with password password. Read above documentation to see how you can do this.

Review comment:
       double `password`

##########
File path: docs/modules/development/pages/deployment-tests.adoc
##########
@@ -0,0 +1,30 @@
+= How to run deployment Tests
+:navtitle: Deployment tests
+
+We wrote some MPT (James' Mail Protocols Tests subproject) deployment tests to 
validate a James
+deployment.
+
+It uses the External-James module, that uses environment variables to locate a 
remote
+IMAP server and run integration tests against it.
+
+For that, the target James Server needs to be configured with a domain domain 
and a user imapuser
+with password password. Read above documentation to see how you can do this.
+
+You have to run MPT tests inside docker. As you need to use maven, the 
simplest option is to
+use james/parent image, and override the entry point ( as git and maven are 
already configured
+there ) :
+
+    $ export JAMES_ADDRESS=127.0.0.1
+    $ export JAMES_IMAP_PORT=143
+    $ export JAMES_SMTP_PORT=25
+
+    $ mvn -T 1C -DskipTests -pl 
org.apache.james:apache-james-mpt-external-james -am install
+    $ mvn -T 1C -pl org.apache.james:apache-james-mpt-external-james test 
-Pintegration-tests\

Review comment:
       remove " \ " 

##########
File path: README.adoc
##########
@@ -5,7 +5,7 @@ 
image:https://img.shields.io/badge/Join%20us-Mailing%20lists-purple.svg[link="ht
 
link:https://gitter.im/apache/james-project[image:https://badges.gitter.im/apache/james-project.svg[Join
 the chat at link:https://gitter.im/apache/james-project]]
 
image:https://img.shields.io/badge/CI-Jenkins%40Apache-blue.svg[link="https://ci-builds.apache.org/job/james/job/ApacheJames/";]
 
image:https://img.shields.io/badge/Documentation-green.svg[link="https://james.apache.org/documentation.html";]
-image:https://img.shields.io/badge/Downloads-yellow.svg[link="https://james.apache.org/download.cgi";]
+image:https://img.shields.io/badge/Downloads-3.6.0-yellow.svg[link="https://james.apache.org/download.cgi";]

Review comment:
       Should we use https://archive.apache.org/dist/james/server/3.6.0/ ? 

##########
File path: README.adoc
##########
@@ -93,7 +93,7 @@ Useful options includes:
 
 == How to run James in Docker
 
-This feature is available for three configurations :
+We maintain docker distribution for our Guice based applications :

Review comment:
       ```suggestion
   We maintain docker distribution for our 
link:https://github.com/google/guice[Guice] based applications:
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org
For additional commands, e-mail: notifications-h...@james.apache.org