grault opened a new pull request #715:
URL: https://github.com/apache/james-project/pull/715


   // reopening https://github.com/linagora/james-project/pull/4421 here as per 
@chibenwa 's request
   
   We use the mock smtp to assert emails sent out from our test environments. 
The GET/DELETE api is very nice, but there's no guarantee that you don't get 
emails between these calls. It could be that by the time you call DELETE, you 
got an extra email that you haven't observed via GET.
   
   One change in this PR is to amend DELETE to return the deleted emails, so 
you can be sure that you only delete emails that you can later observe. It's 
decided to be done this way to maximize backward compatibility for people 
already using DELETE.
   
   We also poll number of emails and not necessarily want to retrieve all the 
emails every time and count them. For this, an extra GET endpoint is added 
which just returns the number of emails currently available in the repository.
   
   For us, it would be nice to have these use cases covered by your upstream 
repo and then we wouldn't have to monitor for changes and rebase our patch on 
top of them. So in case you're not against covering these use cases, we're 
happy to contribute resolving changes in a different form/implementation if 
needed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to