ottoka commented on a change in pull request #753:
URL: https://github.com/apache/james-project/pull/753#discussion_r752098414
##########
File path:
server/data/data-library/src/main/java/org/apache/james/user/lib/model/Algorithm.java
##########
@@ -27,63 +27,53 @@
public class Algorithm {
public enum HashingMode {
- LEGACY(LEGACY_FACTORY),
- DEFAULT(DEFAULT_FACTORY);
+ PLAIN,
+ SALTED,
+ LEGACY,
+ LEGACY_SALTED;
Review comment:
LEGACY_SALTED is what we currently have in our password database, since
we added salting before we knew that it also was legacy mode. It is highly
unlikely anybody else will wind up with this, but I saw no harm including the
option anyway. If you believe this might be too confusing, I can remove
LEGACY_SALTED and keep it as a private patch, until all our users finally
updated their passwords. Just let me know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
