ottoka commented on pull request #750: URL: https://github.com/apache/james-project/pull/750#issuecomment-975650330
> My recommendation is to have the Encryption.getContext method applying the cypher suite and client auth extra configuration before returning it to the caller, thus the caller can safely be ignorant to these details. Ideally, getting read of the getters on cyphers and client auth should also be possible. (I would highly welcome such a refactoring) Seems like a sensible solution to me. But should I do the refactoring in this PR, or is it too far beyond its scope and should be a separate PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
