Arsnael commented on a change in pull request #781:
URL: https://github.com/apache/james-project/pull/781#discussion_r765411188
##########
File path:
server/apps/distributed-app/docs/modules/ROOT/pages/configure/jmap.adoc
##########
@@ -55,6 +55,17 @@ This enables a higher resilience, but the projection needs
to be correctly popul
| Optional boolean. Defaults to true.
| Governs whether authenticated users that do not exist locally should be
created in the users repository.
+
+| authentication.strategy.draft
+| Optional List[String] with delimiter `,` . Specify which authentication
strategies system admin want to use for JMAP draft server.
+If non is specified, JMAP draft server will fallback to default strategies:
Review comment:
```suggestion
If none is specified, JMAP draft server will fallback to default strategies:
```
##########
File path: server/apps/distributed-app/sample-configuration/jmap.properties
##########
@@ -22,3 +22,11 @@ tls.secret=james72laBalle
# Should simple Email/query be resolved against a Cassandra projection, or
should we resolve them against ElasticSearch?
# This enables a higher resilience, but the projection needs to be correctly
populated. False by default.
# view.email.query.enabled=true
+
+# If you want to specified authentication strategies for Jmap draft version
+# For custom Authentication Strategy not inside package
"org.apache.james.jmap.http", you have to specify its FQDN
+#
authentication.strategy.draft=AccessTokenAuthenticationStrategy,JWTAuthenticationStrategy,QueryParameterAccessTokenAuthenticationStrategy,org.apache.james.jmap.custom.authentication.strategy.StrategyA
+
+# If you want to specified authentication strategies for Jmap rfc-8621 version
Review comment:
```suggestion
# If you want to specify authentication strategies for Jmap rfc-8621 version
```
##########
File path: server/apps/memory-app/sample-configuration/jmap.properties
##########
@@ -22,3 +22,11 @@ tls.secret=james72laBalle
# Should simple Email/query be resolved against a Cassandra projection, or
should we resolve them against ElasticSearch?
# This enables a higher resilience, but the projection needs to be correctly
populated. False by default.
# view.email.query.enabled=true
+
+# If you want to specified authentication strategies for Jmap draft version
Review comment:
```suggestion
# If you want to specify authentication strategies for Jmap draft version
```
##########
File path: src/site/xdoc/server/config-jmap.xml
##########
@@ -84,6 +84,19 @@
<dd>Governs whether authenticated users that do not exist
locally should be created in the users repository.
</dd>
+ <dt><strong>authentication.strategy.draft</strong></dt>
+ <dd>List[String] with delimiter ",". Defaults to
AccessTokenAuthenticationStrategy,JWTAuthenticationStrategy,
+ QueryParameterAccessTokenAuthenticationStrategy.</dd>
+ <dd>Specify which authentication strategies system admin
want to use for JMAP draft server.
+ If non is specified, JMAP draft server will fallback to
default strategies:
Review comment:
```suggestion
If none is specified, JMAP draft server will fallback to
default strategies:
```
##########
File path: server/apps/cassandra-app/sample-configuration/jmap.properties
##########
@@ -21,4 +21,12 @@ tls.secret=james72laBalle
# Should simple Email/query be resolved against a Cassandra projection, or
should we resolve them against ElasticSearch?
# This enables a higher resilience, but the projection needs to be correctly
populated. False by default.
-# view.email.query.enabled=true
\ No newline at end of file
+# view.email.query.enabled=true
+
+# If you want to specified authentication strategies for Jmap draft version
Review comment:
```suggestion
# If you want to specify authentication strategies for Jmap draft version
```
##########
File path: server/apps/cassandra-app/sample-configuration/jmap.properties
##########
@@ -21,4 +21,12 @@ tls.secret=james72laBalle
# Should simple Email/query be resolved against a Cassandra projection, or
should we resolve them against ElasticSearch?
# This enables a higher resilience, but the projection needs to be correctly
populated. False by default.
-# view.email.query.enabled=true
\ No newline at end of file
+# view.email.query.enabled=true
+
+# If you want to specified authentication strategies for Jmap draft version
+# For custom Authentication Strategy not inside package
"org.apache.james.jmap.http", you have to specify its FQDN
+#
authentication.strategy.draft=AccessTokenAuthenticationStrategy,JWTAuthenticationStrategy,QueryParameterAccessTokenAuthenticationStrategy,org.apache.james.jmap.custom.authentication.strategy.StrategyA
+
+# If you want to specified authentication strategies for Jmap rfc-8621 version
Review comment:
```suggestion
# If you want to specify authentication strategies for Jmap rfc-8621 version
```
##########
File path: server/apps/memory-app/sample-configuration/jmap.properties
##########
@@ -22,3 +22,11 @@ tls.secret=james72laBalle
# Should simple Email/query be resolved against a Cassandra projection, or
should we resolve them against ElasticSearch?
# This enables a higher resilience, but the projection needs to be correctly
populated. False by default.
# view.email.query.enabled=true
+
+# If you want to specified authentication strategies for Jmap draft version
+# For custom Authentication Strategy not inside package
"org.apache.james.jmap.http", you have to specify its FQDN
+#
authentication.strategy.draft=AccessTokenAuthenticationStrategy,JWTAuthenticationStrategy,QueryParameterAccessTokenAuthenticationStrategy,org.apache.james.jmap.custom.authentication.strategy.StrategyA
+
+# If you want to specified authentication strategies for Jmap rfc-8621 version
Review comment:
```suggestion
# If you want to specify authentication strategies for Jmap rfc-8621 version
```
##########
File path: server/apps/distributed-app/sample-configuration/jmap.properties
##########
@@ -22,3 +22,11 @@ tls.secret=james72laBalle
# Should simple Email/query be resolved against a Cassandra projection, or
should we resolve them against ElasticSearch?
# This enables a higher resilience, but the projection needs to be correctly
populated. False by default.
# view.email.query.enabled=true
+
+# If you want to specified authentication strategies for Jmap draft version
Review comment:
```suggestion
# If you want to specify authentication strategies for Jmap draft version
```
##########
File path:
server/apps/distributed-app/docs/modules/ROOT/pages/configure/jmap.adoc
##########
@@ -55,6 +55,17 @@ This enables a higher resilience, but the projection needs
to be correctly popul
| Optional boolean. Defaults to true.
| Governs whether authenticated users that do not exist locally should be
created in the users repository.
+
+| authentication.strategy.draft
+| Optional List[String] with delimiter `,` . Specify which authentication
strategies system admin want to use for JMAP draft server.
+If non is specified, JMAP draft server will fallback to default strategies:
+`AccessTokenAuthenticationStrategy`, `JWTAuthenticationStrategy`,
`QueryParameterAccessTokenAuthenticationStrategy`
+
+| authentication.strategy.rfc8621
+| Optional List[String] with delimiter `,` . Specify which authentication
strategies system admin want to use for JMAP RFC-8621 server.
+If non is specified, JMAP RFC-8621 server will fallback to default strategies:
Review comment:
```suggestion
If none is specified, JMAP RFC-8621 server will fallback to default
strategies:
```
##########
File path: src/site/xdoc/server/config-jmap.xml
##########
@@ -84,6 +84,19 @@
<dd>Governs whether authenticated users that do not exist
locally should be created in the users repository.
</dd>
+ <dt><strong>authentication.strategy.draft</strong></dt>
+ <dd>List[String] with delimiter ",". Defaults to
AccessTokenAuthenticationStrategy,JWTAuthenticationStrategy,
+ QueryParameterAccessTokenAuthenticationStrategy.</dd>
+ <dd>Specify which authentication strategies system admin
want to use for JMAP draft server.
+ If non is specified, JMAP draft server will fallback to
default strategies:
+ AccessTokenAuthenticationStrategy,
JWTAuthenticationStrategy, QueryParameterAccessTokenAuthenticationStrategy.</dd>
+
+ <dt><strong>authentication.strategy.rfc8621</strong></dt>
+ <dd>List[String] with delimiter ",". Defaults to
JWTAuthenticationStrategy,BasicAuthenticationStrategy.</dd>
+ <dd>Specify which authentication strategies system admin
want to use for JMAP RFC-8621 server.
+ If non is specified, JMAP RFC-8621 server will fallback to
default strategies:
Review comment:
```suggestion
If none is specified, JMAP RFC-8621 server will fallback
to default strategies:
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
