chibenwa commented on a change in pull request #788:
URL: https://github.com/apache/james-project/pull/788#discussion_r767466908
##########
File path:
server/apps/distributed-app/docs/modules/ROOT/pages/configure/imap.adoc
##########
@@ -47,11 +47,9 @@ Defaults to 0 (unlimited). Must be a positive integer,
optionally with a unit: B
| Deprecated. Should use `auth.plainAuthEnabled`, `auth.requireSSL` instead.
Whether to enable Authentication PLAIN if the connection is not encrypted via
SSL or STARTTLS. Defaults to `true`.
-| auth.plainAuthEnabled
-| true or false. Defaults to `true`.
-
| auth.requireSSL
-| true or false. Defaults to `true`.
+| true or false. Defaults to `true`. This is a new way to configure
Authentication PLAIN. Similar to plainAuthDisallowed.
+Whether to enable Authentication PLAIN if the connection is not encrypted via
SSL or STARTTLS.
Review comment:
We don't care about the authentication type here: all type of
authentications should be rejected.
##########
File path: src/site/xdoc/server/config-imap4.xml
##########
@@ -85,10 +85,9 @@
know what you are doing</dd>
<dt><strong>plainAuthDisallowed</strong></dt>
<dd>Deprecated. Should use `auth.plainAuthEnabled`, `auth.requireSSL`
instead. Whether to enable Authentication PLAIN if the connection is not
encrypted via SSL or STARTTLS. Defaults to true.</dd>
- <dt><strong>auth.plainAuthEnabled</strong></dt>
- <dd>true or false. Defaults to true.</dd>
<dt><strong>auth.requireSSL</strong></dt>
- <dd>true or false. Defaults to true.</dd>
+ <dd>true or false. Defaults to true. This is a new way to configure
Authentication PLAIN. Similar to plainAuthDisallowed.
+ Whether to enable Authentication PLAIN if the connection is not
encrypted via SSL or STARTTLS.</dd>
Review comment:
Idem
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
